[Clang] [OMPIRBuilder] Prevent Null Pointer Dereference in OpenMP IR Builder #115506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpenMP IR Builder
Member
|
@llvm/pr-subscribers-flang-openmp Author: None (smanna12) ChangesThe fix in OMPIRBuilder.cpp adds an assertion to ensure that ArgStructType is not null before it is used. Full diff: https://github.com/llvm/llvm-project/pull/115506.diff 1 Files Affected:
diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
index d2e4dc1c85dfd2..869f237ff992cc 100644
--- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -6966,6 +6966,10 @@ static Function *emitTargetTaskProxyFunction(OpenMPIRBuilder &OMPBuilder,
auto *ArgStructType =
dyn_cast<StructType>(ArgStructAlloca->getAllocatedType());
+ assert(ArgStructType &&
+ "Unable to find the struct type corresponding to the alloca "
+ "instruction");
+
AllocaInst *NewArgStructAlloca =
Builder.CreateAlloca(ArgStructType, nullptr, "structArg");
Value *TaskT = ProxyFn->getArg(1);
|
Fznamznon
reviewed
Nov 12, 2024
smanna12
changed the title
Fznamznon
approved these changes
Nov 21, 2024
Contributor
Author
|
Thank you @Fznamznon for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses Static Analyzer issues related to potential null dereference by replacing dyn_cast<> with cast<> in OMPIRBuilder.cpp to ensure that ArgStructType is not null before it is used, improving the stability and reliability of the code.